From 2c3faa9f2eceeab4d517af6c5fddf0007a71584d Mon Sep 17 00:00:00 2001 From: swaggboi Date: Tue, 23 Aug 2022 19:09:08 -0400 Subject: [PATCH] Some TODOs --- PostText.pl | 1 + README.md | 3 +++ lib/PostText/Model/Remark.pm | 1 + 3 files changed, 5 insertions(+) diff --git a/PostText.pl b/PostText.pl index 7483dd1..8f0815f 100755 --- a/PostText.pl +++ b/PostText.pl @@ -135,6 +135,7 @@ group { group { under '/thread'; + # This desperately needs clean-up get '/:thread_id/:remark_page', [thread_id => qr/[0-9]+/, remark_page => qr/[0-9]+/], {remark_page => 1}, sub ($c) { diff --git a/README.md b/README.md index 8f65c13..288bf15 100644 --- a/README.md +++ b/README.md @@ -25,6 +25,7 @@ Run the tests locally (against development environment) ## TODOs 1. Hyperlink to remarks form +1. In remark form, show the parent thread and maybe the last reply too 1. Is there something I can do about route names? 1. I'm kinda hardcoding the single-thread view `link_to` in the templates because I cannot for the life of me figure out how to use @@ -32,3 +33,5 @@ Run the tests locally (against development environment) clean-up the HTML too, just used `` cuz I didn't know what else to use 1. Tests for remark form +1. Marked some items for clean up with comments +1. Method names may need to be shortened diff --git a/lib/PostText/Model/Remark.pm b/lib/PostText/Model/Remark.pm index b643bcc..bb84a82 100644 --- a/lib/PostText/Model/Remark.pm +++ b/lib/PostText/Model/Remark.pm @@ -37,6 +37,7 @@ sub remarks_per_page($self, $value = undef) { $self->{'remarks_per_page'} = $value // $self->{'remarks_per_page'} } +# Probably can clean this up too sub create_remark( $self, $thread_id,