From 50a512f2aefab83323b14ae4a9e3362897e01748 Mon Sep 17 00:00:00 2001
From: swag <swaggboi@slackware.uk>
Date: Tue, 20 Sep 2022 13:45:37 -0400
Subject: [PATCH] More granular tests and cleaned up whitespace in templates

---
 t/post.t                    | 27 +++++++++++++++++++++++----
 templates/post.html.ep      |  6 +++---
 templates/thread_id.html.ep |  6 +++---
 3 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/t/post.t b/t/post.t
index a33b890..7b066c6 100644
--- a/t/post.t
+++ b/t/post.t
@@ -35,11 +35,26 @@ my %invalid_remark = (
 $t->ua->max_redirects(1);
 
 # GET
-$t->get_ok('/post'  )->status_is(200)->text_like(h2 => qr/New Thread/);
-$t->get_ok('/post/1')->status_is(200)->text_like(h2 => qr/New Remark/);
+$t->get_ok('/post')->status_is(200)
+    ->element_exists('form input[name="author"]' )
+    ->element_exists('form input[name="title"]'  )
+    ->element_exists('form textarea[name="post"]')
+    ->element_exists('form input[type="submit"]' )
+    ->text_like(h2 => qr/New Thread/);
+
+$t->get_ok('/post/1')->status_is(200)
+    ->element_exists('form input[name="author"]' )
+    ->element_exists('form textarea[name="post"]')
+    ->element_exists('form input[type="submit"]' )
+    ->text_like(h2 => qr/New Remark/);
 
 # POST
-$t->post_ok('/post'  )->status_is(200)->text_like(h2 => qr/New Thread/);
+$t->post_ok('/post')->status_is(200)
+    ->element_exists('form input[name="author"]' )
+    ->element_exists('form input[name="title"]'  )
+    ->element_exists('form textarea[name="post"]')
+    ->element_exists('form input[type="submit"]' )
+    ->text_like(h2 => qr/New Thread/);
 
 $t->post_ok('/post', form => \%invalid_title)->status_is(400)
     ->text_like(p => qr/Invalid title/);
@@ -48,7 +63,11 @@ $t->post_ok('/post', form => \%invalid_post)->status_is(400)
 $t->post_ok('/post', form => \%valid_params)->status_is(200)
     ->text_like(h2 => qr/Threads List/);
 
-$t->post_ok('/post/1')->status_is(200)->text_like(h2 => qr/New Remark/);
+$t->post_ok('/post/1')->status_is(200)
+    ->element_exists('form input[name="author"]' )
+    ->element_exists('form textarea[name="post"]')
+    ->element_exists('form input[type="submit"]' )
+    ->text_like(h2 => qr/New Remark/);
 
 $t->post_ok('/post/1', form => \%valid_remark)->status_is(200)
     ->text_like(h2 => qr/Thread - #1/);
diff --git a/templates/post.html.ep b/templates/post.html.ep
index ba890c9..f94ba0e 100644
--- a/templates/post.html.ep
+++ b/templates/post.html.ep
@@ -4,11 +4,11 @@
 <form method="post">
   <div class="author field">
     <%= label_for author => 'Author' %>
-    <% if (my $previous_author = session->{'author'}) { %>
+    <% if (my $previous_author = session->{'author'}) { =%>
       <%= text_field author => $previous_author, maxlength => 63, minlength => 1 %>
-    <% } else { %>
+    <% } else { =%>
       <%= text_field author => 'Anonymous', maxlength => 63, minlength => 1 %>
-    <% } %>
+    <% } =%>
     <% if (my $error = validation->error('author')) { =%>
       <p class="field-with-error">Invalid author: 1 to 63 characters please.</p>
     <% } =%>
diff --git a/templates/thread_id.html.ep b/templates/thread_id.html.ep
index f0f6716..4f5a582 100644
--- a/templates/thread_id.html.ep
+++ b/templates/thread_id.html.ep
@@ -4,11 +4,11 @@
 <form method="post">
   <div class="author field">
     <%= label_for author => 'Author' %>
-    <% if (my $previous_author = session->{'author'}) { %>
+    <% if (my $previous_author = session->{'author'}) { =%>
       <%= text_field author => $previous_author, maxlength => 63, minlength => 1 %>
-    <% } else { %>
+    <% } else { =%>
       <%= text_field author => 'Anonymous', maxlength => 63, minlength => 1 %>
-    <% } %>
+    <% } =%>
     <% if (my $error = validation->error('author')) { =%>
     <p class="field-with-error">Invalid author: 1 to 63 characters please.</p>
     <% } =%>