captcha for flag_remark

lib/PostText/Controller/.#Thread.pm

@@ -0,0 +1 @@
+daniel@graymember.5691

lib/PostText/Controller/Remark.pm

@@ -65,18 +65,28 @@ sub create($self) {
 
 sub flag($self) {
     my $remark_id = $self->param('remark_id');
+    my $v         = $self->validation;
+
+    $v->optional(captcha => 'trim')->size(4, 4)->like(qr/flag/i);
+
+    if ($v->is_valid) {
         my $thread_id    = $self->remark->thread_id_for($remark_id);
         my $redirect_url =
             $self->url_for('single_thread', thread_id => $thread_id)
                 ->fragment('info')->to_abs;
 
-
         $self->remark->flag($remark_id);
         $self->flash(
             info => "Remark #$remark_id has been flagged for moderator. 🚩"
             );
 
-    $self->redirect_to($redirect_url);
+        return $self->redirect_to($redirect_url);
+    }
+    elsif ($v->has_error) {
+        $self->stash(status => 400)
+    }
+
+    return $self->render;
 }
 
 1;

lib/PostText/Controller/Thread.pm

@@ -157,7 +157,7 @@ sub bump($self) {
         $self->stash(status => 400)
     }
 
-    $self->render;
+    return $self->render;
 }
 
 sub flag($self) {

t/remark.t

@@ -48,9 +48,10 @@ subtest 'Flagging remark', sub {
         ->element_exists('a[href*="flag"]')
         ->text_like(h2 => qr/Remark #1/);
 
-    $t->get_ok('/remark/flag/1')->status_is(200)
+    $t->get_ok('/remark/flag/1'    )->status_is(200);
-        ->element_exists('p[class="stash-with-info"]')
+    $t->get_ok('/remark/flag/65536')->status_is(404);
-        ->text_like(p => qr/Remark #1 has been flagged/);
+    $t->get_ok('/remark/flag/1', form => {captcha => 'flag'})->status_is(200);
+    $t->get_ok('/remark/flag/1', form => {captcha => 'aaaa'})->status_is(400);
 };
 
 done_testing;

t/thread.t

@@ -90,7 +90,8 @@ subtest 'Bumping thread', sub {
 
     $t->get_ok('/thread/bump/1'    )->status_is(200);
     $t->get_ok('/thread/bump/65536')->status_is(404);
-    $t->get_ok('/thread/bump/1', form => {captcha => 'bump'})->status_is(400);
+    $t->get_ok('/thread/bump/1', form => {captcha => 'bump'})->status_is(200);
+    $t->get_ok('/thread/bump/1', form => {captcha => 'aaaa'})->status_is(400);
 };
 
 subtest 'Flagging thread', sub {
@@ -104,7 +105,8 @@ subtest 'Flagging thread', sub {
 
     $t->get_ok('/thread/flag/1'    )->status_is(200);
     $t->get_ok('/thread/flag/65536')->status_is(404);
-    $t->get_ok('/thread/flag/1', form => {captcha => 'flag'})->status_is(400);
+    $t->get_ok('/thread/flag/1', form => {captcha => 'flag'})->status_is(200);
+    $t->get_ok('/thread/flag/1', form => {captcha => 'aaaa'})->status_is(400);
 };
 
 done_testing;

templates/remark/flag.html.ep

@@ -0,0 +1,17 @@
+% layout 'default';
+% title $remark_id ? "Flag Remark #$remark_id" : '?';
+<h2 class="page-title"><%= title %></h2>
+<% if ($remark_id) { =%>
+<form class="form-body">
+  <div class="form-field">
+    <% if (my $error = validation->error('captcha')) { =%>
+    <p class="field-with-error">Must be between <%= $error->[2] %>
+      and <%= $error->[3] %> characters.</p>
+    <% } =%>
+    <%= label_for captcha => "Enter the word 'flag' to confirm:" %>
+    <%= text_field captcha => id => 'captcha' %>
+  </div>
+  <button type="submit" class="form-button">Confirm</button>
+  </fieldset>
+</form>
+<% } =%>