swaggboi/guestbook-ng
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

expires vs expiration

Browse Source 
It appears I have misunderstood the difference between `expires =>
time() + 3600` and `expiration => 3600` as I thought `expires` would
just set the expiration one time and not update for subsequent
requests. Per this discussion thread, that does not appear to be
correct:

https://github.com/mojolicious/mojo/discussions/1833

Thus I felt it best to just set the expiry period to 30 min and allow
that to reset on subsequent requests rather than reinvent the wheel
This commit is contained in:
swag 2022-04-04 17:22:23 -04:00
parent a36e43ea11
commit 80b2acb79a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
guestbook-ng.pl
View File

@ -43,14 +43,10 @@ under sub ($c) {
unless ($c->session('counted')) { unless ($c->session('counted')) {
$c->counter->increment_visitor_count(); $c->counter->increment_visitor_count();
$c->session( $c->session(
expires => time() + 3600, expiration => 1800,
counted => 1 counted => 1
); );
} }
# Delete this since I was supposed to be using 'expires' instead
# of 'expiration'; the difference is outlined here:
# https://docs.mojolicious.org/Mojolicious/Controller#session
delete $c->session->{'expiration'} if $c->session('expiration');
$c->stash(status => 403) if $c->flash('error'); $c->stash(status => 403) if $c->flash('error');