swaggboi/PostText
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some TODOs

Browse Source
This commit is contained in:
swaggboi 2022-08-23 19:09:08 -04:00
parent e73170c1f2
commit 2c3faa9f2e
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PostText.pl
View File

@ -135,6 +135,7 @@ group {
group { group {
under '/thread'; under '/thread';
# This desperately needs clean-up
get '/:thread_id/:remark_page', get '/:thread_id/:remark_page',
[thread_id => qr/[0-9]+/, remark_page => qr/[0-9]+/], [thread_id => qr/[0-9]+/, remark_page => qr/[0-9]+/],
{remark_page => 1}, sub ($c) { {remark_page => 1}, sub ($c) {

3
README.md
View File

@ -25,6 +25,7 @@ Run the tests locally (against development environment)
## TODOs ## TODOs
1. Hyperlink to remarks form 1. Hyperlink to remarks form
1. In remark form, show the parent thread and maybe the last reply too
1. Is there something I can do about route names? 1. Is there something I can do about route names?
1. I'm kinda hardcoding the single-thread view `link_to` in the 1. I'm kinda hardcoding the single-thread view `link_to` in the
templates because I cannot for the life of me figure out how to use templates because I cannot for the life of me figure out how to use
@ -32,3 +33,5 @@ Run the tests locally (against development environment)
clean-up the HTML too, just used `<span>` cuz I didn't know what clean-up the HTML too, just used `<span>` cuz I didn't know what
else to use else to use
1. Tests for remark form 1. Tests for remark form
1. Marked some items for clean up with comments
1. Method names may need to be shortened

1
lib/PostText/Model/Remark.pm
View File

@ -37,6 +37,7 @@ sub remarks_per_page($self, $value = undef) {
$self->{'remarks_per_page'} = $value // $self->{'remarks_per_page'} $self->{'remarks_per_page'} = $value // $self->{'remarks_per_page'}
} }
# Probably can clean this up too
sub create_remark( sub create_remark(
$self, $self,
$thread_id, $thread_id,